Gherkin unique picklestep ids #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also regenerated Golden JSON to port the bugfix to other languages
|
Note: this also fix the last failing tests in #793 :) |
Ajwah
pushed a commit
to Ajwah/ex-gherkin
that referenced
this pull request
Jul 23, 2020
In the past 6 months, `cucumber/cucumber`-repo has seen a variet of changes all of which have been fixed with this commit: * background to have `id` * rule to have `id` * examples to have `id` * ensure to only strip leading and trailing spaces in table cells. Keep newline intact * ensure escaped delimiter within doc_string is not recorded as escaped * doc_string has field change: contentType -> mediaType * ignore comments on tags See: cucumber/common#891 cucumber/common#880 cucumber/common#889 cucumber/common#800 At the time of this commit, master for `cucumber/cucumber` was at: a7c593f479e7ae739b49108f79bba4853352d99c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
gherkincomputes the pickles in a feature file containing aBackground, thePickleSteporiginating from the background all share the sameid(which is obviously bad).This fixes it.
How Has This Been Tested?
The feature testing the background has now 2 scenarios (and the GOLDEN Json generated from it shows 2 different ids for the steps).
Also, a new
complex_background.featurefile has been added, with aBackground, anotherBackgroundinside aRuleand also a scenario with examples.Types of changes
Checklist: