Fixing non valid preprocessor warning on msvc #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paoloambrosio
requested changes
Oct 22, 2016
| @@ -1,4 +1,8 @@ | |||
| #warning Use of defs.hpp is deprecated, please use either autodetect.hpp or generic.hpp | |||
| #ifdef __GNUC__ | |||
| #warning "Use of defs.hpp is deprecated, please use either autodetect.hpp or generic.hpp" | |||
There was a problem hiding this comment.
Indent the #warning that is inside the if block
| #ifdef __GNUC__ | ||
| #warning "Use of defs.hpp is deprecated, please use either autodetect.hpp or generic.hpp" | ||
| #else | ||
| #pragma message( "Use of defs.hpp is deprecated, please use either autodetect.hpp or generic.hpp" ) |
There was a problem hiding this comment.
Indent the #pragma that is inside the else block
aallrd
force-pushed
the
preprocessor-warning-fix
branch
from
6c83029 to
3abd374
Compare
|
I updated my change with a 4 spaces indentation. |
paoloambrosio
approved these changes
Oct 25, 2016
paoloambrosio
added a commit
to paoloambrosio/cucumber-cpp
that referenced
this pull request
Oct 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#warningkeyword is not understood by the msvc preprocessor, throwing the below fatal error:fatal error C1021: invalid preprocessor command 'warning'This fix provides msvc portability for the preprocessor warning message.