Disable Nagle on TCP socket: too slow for interactive #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wire-protocol is latency-bound, not bandwidth-constrained. So disable the Nagle algorithm to prevent large delays from hurting our performance too much. NOTE: Considering that we are implementing a request-reply protocol it might be possible to improve performance without disabling the Nagle algorithm. E.g. by taking control over buffering ourselves instead of leaving it up to the iostream class.
paoloambrosio
approved these changes
Oct 25, 2016
paoloambrosio
added a commit
to paoloambrosio/cucumber-cpp
that referenced
this pull request
Oct 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wire-protocol is latency-bound, not bandwidth-constrained. So disable the Nagle algorithm to prevent large delays from hurting our performance too much.
This about divides my runtime in half.
NOTE: Considering that we are implementing a request-reply protocol it might be possible to improve performance without disabling the Nagle algorithm. E.g. by taking control over buffering ourselves instead of leaving it up to the iostream class.