Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: output CTest error log on failures #133

Merged
merged 1 commit into from
Mar 22, 2017
Merged

Travis: output CTest error log on failures #133

merged 1 commit into from
Mar 22, 2017

Conversation

muggenhor
Copy link
Contributor

This causes CTest to output the stdout/stderr log of failing test cases when encountered.

Copy link
Member

@paoloambrosio paoloambrosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course this is a welcome addition!

It is missing changes to the AppVeyor build.

@@ -3,6 +3,9 @@ set -e #break script on non-zero exitcode from any command
gem install bundler
bundle install

CTEST_OUTPUT_ON_FAILURE=ON
export CTEST_OUTPUT_ON_FAILURE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it can be shortened as export CTEST_OUTPUT_ON_FAILURE=ON

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's a short hand in bash and other korn shell derivatives. Bourne shell (/bin/sh) doesn't support that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Wasn't aware that Dash (/bin/sh in most Linux distributions, as opposed to Bash in OSX) did not support that.

@konserw
Copy link
Contributor

konserw commented Jan 28, 2017

I think this should be merged - @paoloambrosio ?

@muggenhor
Copy link
Contributor Author

FYI: I think it's ready to be merged.

@paoloambrosio paoloambrosio merged commit 2dedbd4 into cucumber:master Mar 22, 2017
@muggenhor muggenhor deleted the travis-output-ctest-failure branch March 23, 2017 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants