-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #81 by intercepting messages from BOOST_*_MESSAGE macros #164
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
@boost | ||
Feature: Check macros used with boost test driver | ||
|
||
This is just a simple feature meant to test boost's | ||
specyfic validation macros interop with cucumber. | ||
|
||
Scenario Outline: <check> macro | ||
Given the following feature: | ||
""" | ||
Feature: Feature name | ||
Scenario: Scenario name | ||
Given a step | ||
""" | ||
And a step definition file with: | ||
""" | ||
#include <boost/test/unit_test.hpp> | ||
#include <cucumber-cpp/autodetect.hpp> | ||
GIVEN("a step") { | ||
<check>; | ||
} | ||
""" | ||
When Cucumber runs the feature | ||
Then the scenario <passes or fails?> | ||
|
||
Examples: | ||
| check | passes or fails? | | ||
| BOOST_CHECK(false) | fails | | ||
| BOOST_CHECK_MESSAGE(false, "boost message") | fails with message "boost message" | | ||
| BOOST_ERROR("boost message") | fails with message "boost message" | | ||
| BOOST_FAIL("boost message") | fails with message "boost message" | | ||
| BOOST_REQUIRE(false) | fails | | ||
| BOOST_REQUIRE_MESSAGE(false, "boost message") | fails with message "boost message" | | ||
| BOOST_WARN(false) | passes | | ||
| BOOST_WARN_MESSAGE(false, "boost message") | passes | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't do this: this causes warnings about "unused parameters", that's the reason it was commented out like that in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we are actually using them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grep for unused and for param hasn't show me any warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, nevermind, I didn't notice that you changed the empty inline function (
{}
) to just a declaration with the function's definition elsewhere.As for warnings: you should compile with
-Wall -Wextra
to see any. I think we should probably consider building with that one plus-Werror
by default on our CI systems at least.The old code (with empty inline function definition) without commented out parameter produces this with `-DCMAKE_CXX_FLAGS='-Wall -Wextra -Werror':
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we are doing so for debug builds, but now I can see that there is only -Weffc++ being set for those. We could add those flags to CMAKE_CXX_FLAGS_DEBUG in CMakelists ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just submitted 3ec9d03 which enables warnings for all GCC/Clang builds. I don't think it makes sense to make it dependent on the build type. Adding
-Werror
is something we should do only when the warnings are fixed.