Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves compile error with Boost 1.71.0 #230

Closed
wants to merge 1 commit into from
Closed

Resolves compile error with Boost 1.71.0 #230

wants to merge 1 commit into from

Conversation

dionisioedu
Copy link

@dionisioedu dionisioedu commented Dec 9, 2019

Summary

Details

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to master, keeping only relevant commits.

@dionisioedu
Copy link
Author

There is a new virtual function on the boost::unit_test::unit_test_log_formatter in a new version of boost.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.47% when pulling 66ff5c8 on dionisioedu:feature/compile-for-boost-107100 into dd424c1 on cucumber:master.

@LukasWoodtli
Copy link
Contributor

This is basically a duplicate of #225 and #227. As far as I know the API change is already in Boost 1.70 so the version check is not right in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants