Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Qt on CI system #251

Merged
merged 1 commit into from
Sep 30, 2022
Merged

add Qt on CI system #251

merged 1 commit into from
Sep 30, 2022

Conversation

ursfassler
Copy link
Contributor

@ursfassler ursfassler commented Sep 30, 2022

Summary

Execute Qt tests on CI.

Details

Adding Qt to the CI system.

Motivation and Context

The Qt tests are not run on the CI system because they are not found. We may not know about a broken state for a long time.

This is a base to add another fix for the latest Qt versions: https://github.com/ursfassler/cucumber-cpp/tree/fix-build-with-qt5.15.2.

How Has This Been Tested?

With the github action.

Types of changes

  • Bug fix (in the CI system) (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to master, keeping only relevant commits.

@mpkorstanje mpkorstanje merged commit 15d73be into cucumber:main Sep 30, 2022
@mpkorstanje
Copy link
Contributor

Cheers! Would you mind looking at the appveyor tests too? If they're not duplicates of the current set of tests in GitHub?

@ursfassler ursfassler deleted the test-qt-on-ci branch September 30, 2022 10:46
@ursfassler
Copy link
Contributor Author

The appveyor tests seem to use Qt, but only run on Windows. All of them fail during gem install bundle.
Is this what you asked for? Should we discuss the whole appveyor topic in a bug report?

@mpkorstanje
Copy link
Contributor

That seems reasonable. Though I wouldn't know what to fix about it and wouldn't be able to contribute much. I'm mostly merging everything that looks reasonable to keep momentum going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants