Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: programmatically generate temporary file name in test #265

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

ursfassler
Copy link
Contributor

Summary

Latest gcc throws errors when using tmpnam. Generate temporary file name within the test to work around. It has the same shortcomings as using tmpnam, but they are no risk as it is used only in the tests.

Details

Motivation and Context

Test didn't compile anymore on my Linux machine.

How Has This Been Tested?

It is within a test. The test passes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to main, keeping only relevant commits.

Latest gcc throws errors when using tmpnam. Generate temporary file name
within the test to work around. It has the same shortcomings as using
tmpnam, but they are no risk as it is used only in the tests.
@ursfassler ursfassler marked this pull request as ready for review December 10, 2023 20:30
@ursfassler ursfassler merged commit 147aa92 into cucumber:main Dec 10, 2023
1 check passed
@ursfassler ursfassler deleted the tmpfile branch December 10, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant