Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove broken E2E tests #272

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Conversation

ursfassler
Copy link
Contributor

Summary

Remove broken E2E tests.

Details

Motivation and Context

The E2E/feature-tests depend on the outdated Cucumber Technology Compatibility Kit.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to main, keeping only relevant commits.

The E2E/feature-tests depend on the outdated Cucumber Technology
Compatibility Kit.
@ursfassler ursfassler marked this pull request as ready for review December 27, 2023 10:10
@ursfassler ursfassler merged commit 845e835 into cucumber:main Dec 27, 2023
2 checks passed
@ursfassler ursfassler deleted the remove-e2e-tests branch December 27, 2023 10:16
@luke-hill
Copy link
Contributor

FYI the CCK has been updated a lot recently. It's likely that to get things working / passing you'll need a "set" of updates to all the ruby based technologies at the same time.

I know you're still firefighting a lot here, so let me know if I can be of any help and I'll try where possible to help.

The wire gem "should" now be almost fully re-conformant and using a semi up to date version of cucumber ruby

@ursfassler
Copy link
Contributor Author

The E2E test used the archived Cucumber Technology Compatibility Kit (TCK). The CCK (Cucumber Compatibility Kit) does verify a bit different things and is not used by cucumber-cpp (please correct me if I am mixing up something, it is a bit confusing).

I'd like to integrate CCK, but it seems to only make sense once we support Cucumber Expressions (that would be awesome, because the regexes are bugging me the most when I'm using cucumber-cpp in a project).

@luke-hill
Copy link
Contributor

Sorry you are right. I missed something. Ignore my comment, I was wrong. You are indeed right about it all.

Next step imo is to establish some semi-conformance to using up to date ruby techs. I can either create an issue or let you attack it head on. Either is fine by me.

@ursfassler
Copy link
Contributor Author

I am not sure what you are talking about 🙈 => would be good to have an issue to explain it a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants