Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No googletest auto-download #279

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Conversation

ursfassler
Copy link
Contributor

@ursfassler ursfassler commented Dec 30, 2023

Summary

Use find-gtest from cmake and don't automatically download gtest.

Details

Use same method for gtest as for the other external dependencies; they have to be provided externally.
Increase needed versions of cmake to 3.9 and gtest to 1.11.0.

Motivation and Context

This change is motivated by:

  • Use find-gtest from cmake, no special solution
  • use same strategy for all external dependencies (no automatic download)
  • automatic download of gtest was troublesome in some projects where gtest is already used

How Has This Been Tested?

  • automated tests
  • run against project using cucumber-cpp

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

It may break some projects because googletest has to be provided. Code is not affected.

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to main, keeping only relevant commits.

All compiler should support variadic templates by now.
Use same method for gtest as for the other external dependencies; they have
to be provided externally.
@ursfassler ursfassler marked this pull request as ready for review December 30, 2023 09:25
@ursfassler ursfassler changed the title Googletest No googletest auto-download Dec 30, 2023
@ursfassler ursfassler merged commit 95e6b70 into cucumber:main Dec 30, 2023
2 checks passed
@ursfassler ursfassler deleted the googletest branch December 30, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant