GUI Calculator example with Qt libraries #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| project(CalcQt) | ||
|
|
||
| find_package(Qt4 REQUIRED QtCore QtGui QtTest) | ||
| include(${QT_USE_FILE}) |
There was a problem hiding this comment.
Without QT, CMake fails:
CMake Error at /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:97 (MESSAGE):
Could NOT find Qt4 (missing: QT_QMAKE_EXECUTABLE QT_MOC_EXECUTABLE
QT_RCC_EXECUTABLE QT_INCLUDE_DIR QT_LIBRARY_DIR QT_QTCORE_INCLUDE_DIR
QT_QTCORE_LIBRARY QT_QTGUI_INCLUDE_DIR QT_QTGUI_LIBRARY
QT_QTTEST_INCLUDE_DIR QT_QTTEST_LIBRARY QT_UIC_EXECUTABLE)
Call Stack (most recent call first):
/usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:288 (_FPHSA_FAILURE_MESSAGE)
/usr/share/cmake-2.8/Modules/FindQt4.cmake:1200 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
examples/CalcQt/CMakeLists.txt:3 (find_package)
-- Configuring incomplete, errors occurred!
Can you make it optional? You can simply skip it if QT libs are not found or prompt a warning message and continue.
There was a problem hiding this comment.
I agree. I will fix it asap.
|
Thanks for the contribution! A few notes... IMO the wait times should be configurable (perhaps from an environment variable?) so that the tests can run at full speed in an integration server and with wait times for manual and demo purposes. Please check that the C++ code style matches that of the rest of the project. |
added 2 commits
June 2, 2013 20:03
…or each step. Skip compilation when FindQt4 fails. Cleaned indentation and curly brackets. Removed commented code and useless includes.
paoloambrosio
added a commit
that referenced
this pull request
Jun 3, 2013
GUI Calculator example with Qt libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.