-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic driver #99
Generic driver #99
Conversation
#ifdef CUKE_ENABLE_GENERICDRIVER | ||
#include "GenericDriver.hpp" | ||
#else | ||
#error Please #inlude testing framework before cucumber-cpp or #define CUKE_ENABLE_GENERICDRIVER explicitly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo #inlude
=> #include
PR looks OK (see comments) but I have to say that I don't like much the macro Current With testing framework:
Without testing framework:
Proposed With testing framework (it errors if it can't find it):
Without testing framework (using the generic driver):
Under the hood, |
...or perhaps instead of introducing Revised proposal With testing framework (it errors if it can't find it):
Without testing framework (using the generic driver as fallback if not found - backward compatible):
|
Added a test for the Generic Driver and removed duplication in paoloambrosio/cucumber-cpp@22c427a. Please include it in this PR. |
I think that both your commits are good ;) I'm testing them right now and I'll push them in a second :) |
I've rebased it once again. I believe now it is ready ;) |
My proposition for issue:
Error when no testing framework is detected #80