Define biginteger, bigdecimal, byte, short, long, double for all implementations #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslakhellesoy
changed the title
java/src/test/java/io/cucumber/cucumberexpressions/CucumberExpressionTest.java
Outdated
Show resolved
Hide resolved
…ressionTest.java Co-authored-by: Aurélien Reeves <aurelien.reeves@smartbear.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the numeric precision parameter types from the Java implementation in other implementations:
bigintegerbigdecimalbyteshortlongdoubleMotivation & context
In
@cucumber/language-service(written in TypeScript) we need to construct a registry with types that match any implementation. If we don't do that, an error will be thrown when we encounter a parameter type such as{double}when we process Cucumber Expressions from Java. Therefore, all implementations must have the same built-in parameter types.Moreover, this improves numeric type support for all implementations.
Type of change