wait for stream to finish at end of publish plugin (#2322)

cucumber · Sep 3, 2023 · 2c6161e · 2c6161e
1 parent 0a9fad0
commit 2c6161e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,9 @@ Please see [CONTRIBUTING.md](./CONTRIBUTING.md) on how to contribute to Cucumber
 ### Added
 - Support array notation of formats with path in configuration files ([#2318](https://github.com/cucumber/cucumber-js/pull/2318))
 
+### Fixed
+- Wait for stream to finish at end of publish plugin ([#2322](https://github.com/cucumber/cucumber-js/pull/2322))
+
 ## [9.4.0] - 2023-08-12
 ### Fixed
 - Fix type import from cucumber-expressions ([#2310](https://github.com/cucumber/cucumber-js/pull/2310))

diff --git a/src/publish/publish_plugin.ts b/src/publish/publish_plugin.ts
@@ -35,8 +35,13 @@ export const publishPlugin: Plugin = async ({
   stream.pipe(readerStream)
   stream.on('error', (error: Error) => logger.error(error.message))
   on('message', (value) => stream.write(JSON.stringify(value) + '\n'))
-  return () => stream.end()
+  return () =>
+    new Promise<void>((resolve) => {
+      stream.on('finish', () => resolve())
+      stream.end()
+    })
 }
+
 /*
 This is because the Cucumber Reports service returns a pre-formatted console message
 including ANSI escapes, so if our stderr stream doesn't support those we need to