Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry Cucumber Instrumentation #2174

Closed
Ugzuzg opened this issue Nov 6, 2022 · 2 comments
Closed

OpenTelemetry Cucumber Instrumentation #2174

Ugzuzg opened this issue Nov 6, 2022 · 2 comments
Labels
plugins-usecase A use case that could potentially by served by our nascent plugins concept ✅ accepted The core team has agreed that it is a good idea to fix this ⚡ enhancement Request for new functionality

Comments

@Ugzuzg
Copy link
Contributor

Ugzuzg commented Nov 6, 2022

I'm working on an OpenTelemetry Instrumentation for Cucumber.

🤔 What's the problem you've observed?

✨ Do you have a proposal for making it better?

📚 Any additional context?

Passing scenario:
image

A trace of a scenario that was retried (current implementation):
image

@davidjgoss
Copy link
Contributor

First off thanks for raising @Ugzuzg and explaining your use case, I’m a fan of otel so this is really great to see.

To your question: yes more than happy to take a PR for that refactor you describe.

But also: it would be much better if you didn’t have to reach into internal functions to do the instrumentation. We’ve been working on a plugin system for extending Cucumber and this seems like a good problem to help move that along. I’ll study your otel PR a bit more for specifics but essentially I’m thinking of having granular lifecycle hooks for injecting custom logic before and after invocations of test cases, steps etc.

@davidjgoss davidjgoss added ✅ accepted The core team has agreed that it is a good idea to fix this ⚡ enhancement Request for new functionality labels Nov 7, 2022
@davidjgoss davidjgoss added the plugins-usecase A use case that could potentially by served by our nascent plugins concept label Feb 13, 2023
@Ugzuzg
Copy link
Contributor Author

Ugzuzg commented Aug 25, 2023

@davidjgoss, the instrumentation was released 11 days ago.

@Ugzuzg Ugzuzg closed this as completed Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins-usecase A use case that could potentially by served by our nascent plugins concept ✅ accepted The core team has agreed that it is a good idea to fix this ⚡ enhancement Request for new functionality
Projects
None yet
Development

No branches or pull requests

2 participants