Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract case run attempt into a method #2175

Merged
merged 2 commits into from
Nov 12, 2022

Conversation

Ugzuzg
Copy link
Contributor

@Ugzuzg Ugzuzg commented Nov 7, 2022

🤔 What's changed?

Extract the code that runs a test case attempt into a new method. The main reason is so that it can be wrapped by an instrumentation to create spans for each attempt:

image

@davidjgoss

⚡️ What's your motivation?

Related to #2174 discussion.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@coveralls
Copy link

coveralls commented Nov 7, 2022

Coverage Status

Coverage increased (+0.001%) to 98.253% when pulling b87fe5b on Ugzuzg:refactor/run-attempt into 4ea3227 on cucumber:main.

@davidjgoss davidjgoss self-requested a review November 12, 2022 16:43
@davidjgoss davidjgoss merged commit 1d5d345 into cucumber:main Nov 12, 2022
@aslakhellesoy
Copy link
Contributor

Hi @Ugzuzg,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@Ugzuzg Ugzuzg deleted the refactor/run-attempt branch November 12, 2022 17:13
@davidjgoss
Copy link
Contributor

This was released in 8.8.0 https://github.com/cucumber/cucumber-js/releases/tag/v8.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants