Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber tests for cucumber-js include a number of undefined steps #221

Closed
simondean opened this issue Aug 9, 2014 · 5 comments
Closed

Comments

@simondean
Copy link
Contributor

Hi. cucumber-js uses Ruby Cucumber and cucumber-js to test itself. The output from these two test runs include a number of undefined scenarios. It's not possible to know if these undefined scenarios are masking regressions. It would be good to use the --strict option with Ruby cucumber and cucumber-js when cucumber-js tests itself.

Ruby Cucumber is executed from the Rakefile

  desc "Run the features through Cucumber (Ruby) and Aruba"
  task :rb do
    sh %{ cucumber -p quiet }
  end

cucumber-js is executed from the package.json

  "scripts": {
    "test": "./bin/cucumber.js && jasmine-node spec"
  },
@simondean
Copy link
Contributor Author

This issue would make use of #58

@jbpros
Copy link
Member

jbpros commented Aug 9, 2014

I had a discussion with @samccone about this. We'd like to only keep the JS suite in the long term, that would probably lower the barrier for entry for people willing to contribute.

@jbpros
Copy link
Member

jbpros commented Dec 21, 2014

#58 is done. We can do this now!

@jbpros jbpros added this to the 0.6 ancillary features milestone Dec 21, 2014
@charlierudolph
Copy link
Member

Fixed in 8daf95b

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants