native base64 encoding, fix for binary attachments #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Can you please add a test that fails without your change and passes with it to better document what was fixed? |
|
@charlierudolph makes sense, added, I used /example/images/favicon.png in the test (needed a binary image file), I hope that's ok. |
|
Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes the
base-64dependency which doesn't support binary input (it throws an error if input is not ASCII), that makes json formatter fail if any attachment is binary (like screenshots are), replacing it node.js native base64 encoding.as a side benefit, native encoding is probably (not measure) faster, and it's one less dependency to care about.