-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colors to pretty formatter #71
Conversation
Thank you very much, I had a quick look at the pull request, it seems good! I will review it properly over the weekend or so. I just moved the developer-related documentation from the README to CONTRIBUTE. I had one little remark regarding the naming conventions on your contribution; instead of losing it after the pull request, I decided to list it as part of the coding guidelines. Here it is. I hope you don't mind the fact I'm reusing your code there. |
@jbpros That's good. Don't be afraid to call out contributors on things that don't align with your vision. |
Formatter.SUCCESSFUL_COLOR = "green"; | ||
Formatter.PENDING_COLOR = "yellow"; | ||
Formatter.UNDEFINED_COLOR = "cyan"; | ||
Formatter.SKIPPED_COLOR = "blue"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge issue here: pending and undefined should be yellow; skipped should be cyan. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, ok. Doing that.
Why was this never added to the master branch ? |
Is this feature implemented? I'm not seeing any colours in either pretty or standard formatted output. In fact, I'm not seeing any indication, colour or otherwise, or which features / steps are not passing. I just see a summary that one of my features is pending, but unless I'm missing something there is no way to see which. If it's relevant, I'm using linux and running tests as an |
@Foo42 the color output feature has not been merged into the master branch yet. If you want colors you can checkout the color branch on this repo, |
I should clarify that I do see output for failing features, just not which are pending it seems. @atrniv I don't suppose there's a way to get either the color branch or your fork via npm is there? |
@Foo42 , yes you can ! npm is awesome that way :), just add the line below to your package.json
or if you want to use the main repo itself then you can just point it to the last commit on the colors branch with this line.
|
Closing this as we're working on colors based on PR #104. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Add colors to pretty formatter and summarizer (optional), using the commonjs-ansi-color dependency.
@jbpros This still needs tests, but sending your way to see if you have comments on the approach first. Current tests pass.