Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: scoped package name #1411

Merged
merged 10 commits into from
Sep 5, 2020
Merged

build: scoped package name #1411

merged 10 commits into from
Sep 5, 2020

Conversation

davidjgoss
Copy link
Contributor

This would I guess be the last thing to do before publishing a stable 7.0.0.

Would we want to also publish an update to the current package name as a 6.x.x patch with a message to migrate?

(Also, can't quite figure out what I've missed to get the features working with require-ing the new name.)

@davidjgoss davidjgoss added this to the 7.0.0 milestone Aug 24, 2020
@charlierudolph
Copy link
Member

charlierudolph commented Aug 24, 2020

You'll need to update this https://github.com/cucumber/cucumber-js/blob/master/features/support/hooks.ts#L39 where we symlink cucumber as a node module in the tmp dir that each feature runs in. Similarly will probably need to update this: https://github.com/cucumber/cucumber-js/blob/master/features/support/hooks.ts#L64

@charlierudolph
Copy link
Member

Nevermind, now see that you did that already

@charlierudolph
Copy link
Member

Found the issue. And updated the thrown error so it would be easier to understand in the future.

@davidjgoss
Copy link
Contributor Author

Thanks - interesting that dependency-lint has flagged our own package name as being a missing dev dependency - on all versions of Node, but not on Windows, and not on my Mac either. I'll keep digging...

@charlierudolph
Copy link
Member

Hmm so that appears to be reporting that a binary exposed by it is used in a few places. Not sure why its listed as a devDependency either

@davidjgoss davidjgoss mentioned this pull request Aug 28, 2020
5 tasks
dependency-lint.yml Outdated Show resolved Hide resolved
@davidjgoss
Copy link
Contributor Author

Re the old package, the done thing seems to be to use npm deprecate https://docs.npmjs.com/cli/deprecate

@davidjgoss davidjgoss mentioned this pull request Sep 1, 2020
@charlierudolph charlierudolph marked this pull request as ready for review September 5, 2020 04:23
@charlierudolph charlierudolph merged commit 7cba500 into master Sep 5, 2020
@charlierudolph charlierudolph deleted the scoped-package-name branch September 5, 2020 04:24
Adam-ARK pushed a commit to Adam-ARK/cucumber-js that referenced this pull request Oct 21, 2020
Co-authored-by: Charles Rudolph <charles.w.rudolph@gmail.com>
Adam-ARK pushed a commit to Adam-ARK/cucumber-js that referenced this pull request Oct 21, 2020
Co-authored-by: Charles Rudolph <charles.w.rudolph@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants