typescript: fix types for hook functions so they can return 'skipped' #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjgoss
commented
Jan 16, 2021
| export type TestCaseHookFunctionWithParameter = ( | ||
| arg: ITestCaseHookParameter | ||
| ) => void | Promise<void> | ||
| ) => any | Promise<any> |
There was a problem hiding this comment.
any is obviously a bit broad but I think it's faithful to the API, in the sense that you can return/resolve anything you want from a hook or step function, but skipped and pending have special meaning.
charlierudolph
approved these changes
Feb 2, 2021
|
Very cool. Haven't seen a types test before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1529.
As part of this, added tsd so we can build up a representative set of TypeScript usages and make sure they don't regress.