Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include source reference on parameter type message #2287

Merged
merged 11 commits into from
Jun 22, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented May 28, 2023

🤔 What's changed?

This PR captures a source (uri and line) when defining a parameter type, and then includes that as a SourceReference block when emitting the standard message for the parameter type.

Also, while we're here, it removes the list of "builtin" parameter types maintained in this repo, in favour of using the builtin prop of the parameter types themselves.

⚡️ What's your motivation?

Fixes #2272.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented May 28, 2023

Coverage Status

coverage: 98.497% (+0.005%) from 98.492% when pulling 42d75af on feat/parameter-source-reference into 54ac047 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add source reference on Envelope.parameterType
2 participants