Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guice] Inject static fields prior to before all hooks #2803

Merged

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Sep 28, 2023

πŸ€” What's changed?

⚑️ What's your motivation?

Fixes: #2797

🏷️ What kind of change is this?

  • πŸ› Bug fix (non-breaking change which fixes a defect)

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5bf1679) 84.99% compared to head (bd05dff) 84.95%.

Files Patch % Lines
.../src/main/java/io/cucumber/guice/GuiceFactory.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2803      +/-   ##
============================================
- Coverage     84.99%   84.95%   -0.04%     
+ Complexity     2727     2724       -3     
============================================
  Files           331      331              
  Lines          9542     9539       -3     
  Branches        915      916       +1     
============================================
- Hits           8110     8104       -6     
- Misses         1108     1110       +2     
- Partials        324      325       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@mpkorstanje mpkorstanje force-pushed the guice-inject-static-fields-prior-to-before-all-hooks branch from cf5667c to bd05dff Compare November 25, 2023 16:44
@mpkorstanje mpkorstanje marked this pull request as ready for review November 25, 2023 16:46
@mpkorstanje mpkorstanje merged commit 26329bb into main Nov 25, 2023
7 of 9 checks passed
@mpkorstanje mpkorstanje deleted the guice-inject-static-fields-prior-to-before-all-hooks branch November 25, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BeforeAll hooks are executed before dependency injection
1 participant