[Core] Support custom UUID generators in test runners #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
fix-uuid-generator-option
branch
from
2caea1f to
f580b71
Compare
With #2703 a faster UUID generator was introduced. And while the configuration options were added, they were not actually used by `cucumber-junit`, `cucumber-junit-platform-engine` and `cucumber-testng`.
mpkorstanje
force-pushed
the
fix-uuid-generator-option
branch
from
f580b71 to
0295af0
Compare
jkronegg
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
There are other calls to UUID.randomUUID() in the code, e.g io.cucumber.junit.platform.engine.FeatureResolver or io.cucumber.core.runner.CoreHookDefinition (the call in the create() method consumes about 1.2% of the total time on by usual test project).
Should this PR only be related to UUID generators used in test runners, or in the whole Cucumber framework ? (based on the title, I assume it's only in test runners, but having it for the whole framework could be also desirable)
|
Ooh good one. I'll check it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Made it possible to actually use the custom UUID generators in test runners
⚡️ What's your motivation?
With #2703 a faster UUID generator was introduced. And while the
configuration options were added, they were not actually used by
cucumber-junit,cucumber-junit-platform-engineandcucumber-testng.🏷️ What kind of change is this?
📋 Checklist: