Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(dumb) Fix for Rails4 #256

Merged
merged 3 commits into from
Aug 13, 2013
Merged

(dumb) Fix for Rails4 #256

merged 3 commits into from
Aug 13, 2013

Conversation

JonRowe
Copy link
Contributor

@JonRowe JonRowe commented Jul 30, 2013

Removes minitest stuff from rails/test_help and vendors it.
Updates gemspec to allow versions of rails greater than 3.

Works for me™

Edit It seems like you don't need the integration helpers at all on Rails 4...

@JonRowe
Vendor rails/test_help and remove minitest
dc58077 
Removes minitest stuff from `rails/test_help` and vendors it.
Updates gemspec to allow versions of rails greater than 3.

Works for me™
@mattwynne mattwynne mentioned this pull request Jul 30, 2013
Merged
JonRowe added 2 commits July 30, 2013 22:16
@JonRowe
Remove test_help entirely
c42eb64 
Turns out for the Rails app's i've tried you don't need these lines at
all. Given we're relying on spinning up the app via rack-test.
@JonRowe
restore fixture support
94241cc
@tilsammans tilsammans mentioned this pull request Aug 12, 2013
Closed
Kosmas added a commit that referenced this pull request Aug 13, 2013
@Kosmas
Merge pull request #256 from JonRowe/dumb_fix_for_rails4_test_help
4ee036d 
(dumb) Fix for Rails4
@Kosmas Kosmas merged commit 4ee036d into cucumber:master Aug 13, 2013
Kosmas added a commit that referenced this pull request Aug 13, 2013
@Kosmas
Revert "Merge pull request #256 from JonRowe/dumb_fix_for_rails4_test…
a023440 
…_help"

This reverts commit 4ee036d, reversing
changes made to 0bfe70b.
Kosmas added a commit that referenced this pull request Aug 13, 2013
@Kosmas
Merge pull request #258 from cucumber/revert_pull_request_256
231a81c 
Revert "Merge pull request #256 from JonRowe/dumb_fix_for_rails4_test_he...
@Kosmas
Copy link
Member

Kosmas commented Aug 13, 2013

Travis test fail when merged with master so had to revert it back

@mattwynne
Copy link
Member

What was the build failure?

@JonRowe
Copy link
Contributor Author

JonRowe commented Aug 13, 2013

The build is still failing after reverting this suggesting it was anecdotal.

@JonRowe JonRowe mentioned this pull request Aug 13, 2013
Merged
@JonRowe
Copy link
Contributor Author

JonRowe commented Aug 13, 2013

Travis logs the build is broken due to some postgres migration?

@cpb cpb mentioned this pull request Aug 14, 2013
Closed
@Kosmas
Copy link
Member

Kosmas commented Aug 14, 2013

Most of the failures were about:

undefined local variable or method `postgresql_version' for #ActiveRecord::ConnectionAdapters::SQLite3Adapter:0x000000038ee088 (NameError)

Will try and have a look, but basically the build was passing, I've merged the request as it was passing the the build, the new build was failing, so I thought I revert it to restore the previous working version.

Will try and get a fresh copy of master into my localhost and see what happens from there.

@cpb
Copy link

cpb commented Aug 14, 2013

Thanks for the attention to this @Kosmas

@caboteria
Copy link

@Kosmas, the 'postgresql_version' problem that you're seeing is likely due to a broken version of database_cleaner: DatabaseCleaner/database_cleaner#224

You can work around it by pinning database cleaner to version 1.0.1 until a fixed version is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JonRowe @Kosmas @mattwynne @cpb @caboteria