Skip to content

Commit

Permalink
Merge branch 'main' into refactor/v10_redundant_code
Browse files Browse the repository at this point in the history
  • Loading branch information
luke-hill committed Sep 10, 2024
2 parents c2b3306 + a468bc6 commit 0754a59
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ that need to rely on procedural loading / reloading of files should use method i

### Fixed
- Fixed an issue where a change to one example in compatibility testing wasn't fully adhered to ([luke-hill](https://github.com/luke-hill))
- Fixed an issue for Ruby 3.4.0 where a default hash instantiation was being picked up as keyword arguments ([Jon Rowe](https://github.com/JonRowe))

### Removed
- `StepDefinitionLight` associated methods. The class itself is present but deprecated
Expand Down
4 changes: 4 additions & 0 deletions compatibility/features/attachments/attachments_steps.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,7 @@ def cck_asset_path
When('a PDF document is attached and renamed') do
attach(File.open("#{cck_asset_path}/document.pdf"), 'document/pdf', 'renamed.pdf')
end

When('a link to {string} is attached') do |link|
attach(link, 'text/uri-list')
end
4 changes: 3 additions & 1 deletion lib/cucumber/multiline_argument/data_table.rb
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ def row(row)
def eof; end
end

NULL_CONVERSIONS = Hash.new(strict: false, proc: ->(cell_value) { cell_value }).freeze
# This is a Hash being initialized with a default value of a Hash, DO NOT REFORMAT TO REMOVE {}
# Future versions [3.4.0+] of ruby will interpret these as keywords and break.
NULL_CONVERSIONS = Hash.new({ strict: false, proc: ->(cell_value) { cell_value } }).freeze

# @param data [Core::Test::DataTable] the data for the table
# @param conversion_procs [Hash] see map_column
Expand Down

0 comments on commit 0754a59

Please sign in to comment.