Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unable to determine VERSION #1729

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Fix Unable to determine VERSION #1729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32ca0b6
Add additional files into gemspec
luke-hill Sep 1, 2023
64237c7
Remove un-needed files
luke-hill Sep 1, 2023
bf0cedc
Add changelog update
luke-hill Sep 1, 2023
029b7e0
Merge branch 'main' into hotfix/sep_1
luke-hill Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo

## [Unreleased]

### Fixed
- Cucumber was unable to generate the correct `VERSION` constant ([PR#1729](https://github.com/cucumber/cucumber-ruby/pull/1729) [luke-hill](https://github.com/luke-hill))

## [9.0.0] - 2023-08-31
### Added
- Add option `--retry-total` ([#1669](https://github.com/cucumber/cucumber-ruby/pull/1669))
Expand All @@ -20,8 +23,6 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
with [mini_mime](https://rubygems.org/gems/mini_mime)
([#1695](https://github.com/cucumber/cucumber-ruby/pull/1695))

### Deprecated

### Fixed
- Cucumber may raise NoMethodError when CUCUMBER_COLORS environment was set ([PR#1641](https://github.com/cucumber/cucumber-ruby/pull/1641/) [s2k](https://github.com/s2k))

Expand Down
3 changes: 1 addition & 2 deletions cucumber.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,9 @@ Gem::Specification.new do |s|

s.required_rubygems_version = '>= 3.0.1'
s.files = Dir[
'CHANGELOG.old.md',
'CONTRIBUTING.md',
'README.md',
'LICENSE',
'VERSION',
'lib/**/*'
]
s.executables = ['cucumber']
Expand Down