Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port CCK logic #1748

Merged
merged 41 commits into from
Jan 10, 2024
Merged

Port CCK logic #1748

merged 41 commits into from
Jan 10, 2024

Conversation

luke-hill
Copy link
Contributor

@luke-hill luke-hill commented Jan 5, 2024

Description

Porting the CCK logic over to the gem proper. Will be requiring a major bump at CCK end (Will be a minor here)

Items to complete

  • Cucumber Ruby
    • Changelog entry
    • Refactor of existing code to use new CCK links
    • In "first" iteration we need to ensure we're using the gem's feature files, but our step def, support code and miscellaneous files (Subsequently we should move to only have step/support code and use the remotely found files)
  • CCK
    • Check we're not publishing any bespoke ruby code in the gem (Should only have the single namespace CCK::Examples with a few minor links to determine files
    • Release Major CCK (v15?), which will cause this PR to start going green

Type of change

Please delete options that are not relevant.

  • Refactoring (improvements to code design or tooling that don't change behaviour)
  • New feature (non-breaking change which adds new behaviour)
  • Breaking change (will cause existing functionality to not
    work as expected)
  • If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

@luke-hill luke-hill changed the title Port CCK logic - WIP Port CCK logic Jan 5, 2024
@luke-hill
Copy link
Contributor Author

Predictably this has raised a few issues @davidjgoss - Not sure when I'll get round to them. I think one requires a bug/hotfix in the CCK and maybe 1 of the features (attachments), has some oddities that don't play nicely when moving from 1 repo to another.

@luke-hill luke-hill merged commit 64092da into main Jan 10, 2024
15 checks passed
@luke-hill luke-hill deleted the feature/port_cck_logic branch January 10, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant