Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/cck conformance fix #1756

Merged
merged 17 commits into from
Jul 18, 2024
Merged

Bugfix/cck conformance fix #1756

merged 17 commits into from
Jul 18, 2024

Conversation

luke-hill
Copy link
Contributor

@luke-hill luke-hill commented Jul 9, 2024

This fixes up an existing bug in the CI and also updates CCK to v16

  • Ensure attachments now no longer has redundant hook and blank messages
  • Fix up examples-tables to parse and run new scenarios plus fix up extra steps
  • Refactor existing cucumber-ruby implementation to now lean on external assets instead of duplicating them (I forgot to fix this up ages ago)
  • Renamed local step def files to be snake cased (Of sorts), so they're more conformant to ruby style

Type of change

  • Refactoring (improvements to code design or tooling that don't change behaviour)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (will cause existing functionality to not
    work as expected)

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

@luke-hill luke-hill merged commit f99b285 into main Jul 18, 2024
15 checks passed
@luke-hill luke-hill deleted the bugfix/cck_conformance_fix branch July 18, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant