Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemspec: add runtime dependencies on base64, bigdecimal #1762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Sep 1, 2024

Description

This PR adds dependencies in the Gemfile on gems which are referred to in the code, but which in Ruby 3.4 will not be bundled with Ruby.

If absent, and relying on the bundled-with-Ruby gems, these gems emit warnings in our test suite.

See #1757

Type of change

Please delete options that are not relevant.

  • Refactoring (improvements to code design or tooling that don't change behaviour)

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

If absent, these gems raise warnings.
@olleolleolle olleolleolle changed the title Gemfile: add base64, bigdecimal in order to avoid warnings in test output in test output Sep 1, 2024
@olleolleolle olleolleolle changed the title in test output gemspec: add runtime dependencies on base64, bigdecimal Sep 1, 2024
@olleolleolle
Copy link
Contributor Author

olleolleolle commented Sep 1, 2024

The test that fails (before and after this PR) is about the CCK, cucumber compatibility kit.



  1) Cucumber Compatibility Kit 'attachments' example generates valid message types
     Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }

       expected collection contained:  [:attachment, :attachment, :attachment, :attachment, :attachment, :attachment, :attachment, :attachme... :test_step_started, :test_step_started, :test_step_started, :test_step_started, :test_step_started]
       actual collection contained:    [:attachment, :attachment, :attachment, :attachment, :attachment, :attachment, :attachment, :attachme... :test_step_started, :test_step_started, :test_step_started, :test_step_started, :test_step_started]
       the missing elements were:      [:attachment, :step_definition]
     Shared Example Group: "cucumber compatibility kit" called from ./compatibility/cck_spec.rb:13
     # ./compatibility/support/shared_examples.rb:22:in `block (2 levels) in <top (required)>'

@luke-hill
Copy link
Contributor

@olleolleolle not forgotten about this. I know what needs fixing and where, will be doing it soon

@luke-hill
Copy link
Contributor

It would be good to get a grasp on where these are required, and if we can push any deps into the core engine, as I'm trying to get v10 to move most of the requirements into core.

@luke-hill
Copy link
Contributor

Update - not forgot bout this @olleolleolle - Next version is v10 which has a few breaking version changes. This will be in that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants