Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .net 8 to test platforms #158

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Added .net 8 to test platforms #158

merged 1 commit into from
Sep 7, 2023

Conversation

Romfos
Copy link
Contributor

@Romfos Romfos commented Aug 23, 2023

🤔 What's changed?

  • .NET sdk was updated to version 8
  • Added .NET 8 to test platforms (new test platforms: .net 6, .net 7, .net 8)
  • Use c# lang version 12

⚡️ What's your motivation?

.NET 8 soon will be released. This is LTS version and will be good to add it to testing platforms

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
  • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Users should know about my change
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. But can you rebase on/merge main?

@mpkorstanje mpkorstanje marked this pull request as ready for review September 7, 2023 18:54
@mpkorstanje mpkorstanje merged commit 30824f6 into cucumber:main Sep 7, 2023
2 checks passed
@Romfos
Copy link
Contributor Author

Romfos commented Sep 7, 2023

I would like to wait .net 8 release, this is a draft pr, but because you merged it - ok, lets start testing from preview version =)

@mpkorstanje
Copy link
Contributor

My availability is a bit sparse these days. By the time I'll be able to look at this again there is a good chance 8.0 will have been released 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants