Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 2 compatibility #282

Merged
merged 19 commits into from
Sep 16, 2024
Merged

Conversation

youtux
Copy link
Contributor

@youtux youtux commented Sep 15, 2024

🤔 What's changed?

Dropped python 2 compatibility.

⚡️ What's your motivation?

I want to improve the python codebase, initially adding type annotations. But the python2 compatibility code makes it harder, so since python2 was EOL'd 4 years ago, I'd propose to remove supporting it.

Users needing python2 can still use older versions of the package.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@jsa34
Copy link
Contributor

jsa34 commented Sep 15, 2024

https://github.com/cucumber/gherkin/blob/main/.github/workflows/test-python.yml needs updating to remove py2 from the matrix

@youtux youtux marked this pull request as ready for review September 15, 2024 16:20
Copy link
Contributor

@jsa34 jsa34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
We will resolve the Windows encoding issue separately.

@youtux youtux merged commit 1667cf8 into cucumber:main Sep 16, 2024
40 checks passed
@youtux youtux deleted the python-drop-py2-compat branch September 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants