Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the wrong "Georgian Capital Letter M" #45

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

avsd
Copy link
Contributor

@avsd avsd commented Nov 9, 2022

πŸ€” What's changed?

Replace the wrong "Georgian Capital Letter M" with the correct "Georgian Letter M" in two more locations.

$ grep 'α²›' . -rl
./perl/lib/Gherkin/Generated/Languages.pm
./.git/objects/pack/pack-91cf4a762c46dd4566343962d5711b22f2d75ba3.pack
./c/gherkin.gif
./objective-c/GherkinLanguages/gherkin-languages.json

$ sed -i -e 's/α²›/მ/g' perl/lib/Gherkin/Generated/Languages.pm objective-c/GherkinLanguages/gherkin-languages.json

⚑️ What's your motivation?

Related to the previous fix: #44

🏷️ What kind of change is this?

  • πŸ› Bug fix (non-breaking change which fixes a defect)

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@avsd avsd mentioned this pull request Nov 9, 2022
7 tasks
@mpkorstanje mpkorstanje changed the title Remove the wrong "Georgian Capital Letter M" from two more locations Remove the wrong "Georgian Capital Letter M" Nov 10, 2022
@mpkorstanje mpkorstanje merged commit dcbea82 into cucumber:main Nov 10, 2022
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Nov 10, 2022

Cheers!

And I'm not surprised this got through. I couldn't even review this on my other machine. It just didn't show any problems at all.

@avsd
Copy link
Contributor Author

avsd commented Nov 10, 2022

Actually, this bug has unearthed a limitation in one of the tools (Java?) - extended Unicode characters can't be used in filenames. Not sure if it's a problem though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants