Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to github.com/cucumber/gherkin-go - v9.2.0 #240

Merged
merged 14 commits into from
Mar 5, 2020
Merged

Conversation

lonnblad
Copy link
Member

No description provided.

Signed-off-by: Fredrik Lönnblad <fredrik+github@lonnblad.com>
@codecov
Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #240 into master will decrease coverage by 0.78%.
The diff coverage is 91.41%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #240      +/-   ##
=========================================
- Coverage   83.89%   83.1%   -0.79%     
=========================================
  Files          16      15       -1     
  Lines        2614    2409     -205     
=========================================
- Hits         2193    2002     -191     
+ Misses        297     289       -8     
+ Partials      124     118       -6
Impacted Files Coverage Δ
fmt_progress.go 100% <100%> (ø) ⬆️
fmt_junit.go 95% <100%> (+0.47%) ⬆️
suite_context.go 68.66% <74.41%> (-0.66%) ⬇️
fmt_pretty.go 82.35% <83.33%> (-0.93%) ⬇️
stepdef.go 74.6% <90%> (+2.93%) ⬆️
fmt_cucumber.go 92.43% <96.51%> (-6.13%) ⬇️
suite.go 87.13% <96.61%> (-0.23%) ⬇️
fmt.go 95.43% <96.72%> (+1.26%) ⬆️
fmt_events.go 97.05% <97.77%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee20061...b62eb13. Read the comment docs.

@lonnblad lonnblad requested a review from mxygem February 29, 2020 19:56
suite.go Outdated Show resolved Hide resolved
Copy link
Member

@mxygem mxygem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @lonnblad !! Thank you so much for all the time you've put into this migration and other fixes you've provided. 👏 👏 👏 All of our tests work and you've mentioned that your suite is also working. Lets continue our steps to bringing godog inline with the rest of the Cucumber suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants