Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug then running the example of an API, a feature version need to bump to latest reported 0.8.1 #262 #263

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

denis-trofimov
Copy link
Contributor

Bug then running the example of an API, a feature version need to bump to latest reported 0.8.1 #262

Bug then running the example of an API, a feature version need to bump to latest reported 0.8.1 #262
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #263 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files          16       16           
  Lines        2647     2647           
=======================================
  Hits         2245     2245           
  Misses        278      278           
  Partials      124      124           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a53f6f...05db4cc. Read the comment docs.

@lonnblad
Copy link
Member

lonnblad commented Mar 16, 2020

@denis-trofimov Thanks for reporting the issue and fixing it! :)

@lonnblad lonnblad merged commit 732eff4 into cucumber:master Mar 16, 2020
@aslakhellesoy
Copy link
Contributor

Hi @denis-trofimov,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants