Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to v2 factutrapi #100

Merged
merged 14 commits into from
Mar 8, 2023
Merged

Migration to v2 factutrapi #100

merged 14 commits into from
Mar 8, 2023

Conversation

alexviquez
Copy link
Member

Complete migration of resources to CFDI 4.0 and v2 facturapi:
https://docs.facturapi.io/api/

@alexviquez alexviquez added the enhancement New feature or request label Feb 28, 2023
@alexviquez alexviquez self-assigned this Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #100 (f356ef3) into main (a81f0c6) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f356ef3 differs from pull request most recent head 236051f. Consider uploading reports for the commit 236051f to get more accurate results

@@            Coverage Diff            @@
##              main      #100   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          430       442   +12     
=========================================
+ Hits           430       442   +12     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
facturapi/version.py 100.00% <ø> (ø)
facturapi/http/client.py 100.00% <100.00%> (ø)
facturapi/resources/base.py 100.00% <100.00%> (ø)
facturapi/resources/customers.py 100.00% <100.00%> (ø)
facturapi/resources/invoices.py 100.00% <100.00%> (ø)
facturapi/types/enums.py 100.00% <100.00%> (ø)
facturapi/types/queries.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81f0c6...236051f. Read the comment docs.

LuisBrime
LuisBrime previously approved these changes Feb 28, 2023
Copy link
Contributor

@LuisBrime LuisBrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vaa, que bueno que no fueron tantas cosas para migrar a v2

@alexviquez alexviquez merged commit a4690ec into main Mar 8, 2023
@alexviquez alexviquez deleted the v2 branch March 8, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants