Exceptions #21
Merged
Exceptions #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 138 148 +10
Branches 20 21 +1
=========================================
+ Hits 138 148 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
felipao-mx
requested changes
Jun 3, 2021
| @@ -25,13 +25,18 @@ def user_id_filter_required(self) -> bool: | |||
| async def retrieve_object( | |||
| self, resource_class: Any, resource_id: str | |||
| ) -> Any: | |||
| resource_id = ( | |||
There was a problem hiding this comment.
Es el segundo punto del PR
| @@ -76,18 +81,18 @@ def wrapper_resource_class(cls): | |||
|
|
|||
| @self.delete(path + '/{id}') | |||
| @copy_attributes(cls) | |||
| async def delete(id: str): | |||
| async def delete(id: str, request: Request): | |||
There was a problem hiding this comment.
porque sería necesario acceder al request desde estos métodos?
There was a problem hiding this comment.
Hay situaciones donde el método delete tiene un tiempo de expiración en el body como aquí, este solo puede obtenerse del objeto Request
felipao-mx
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
melo sustituye por eluser_iduser_idcuando no existe en el modelocopy_attributespara no sustituir atributos privadosdeleteel objetoRequest. Requerido cuando necesitas acceder al cuerpo de la petición