error handlers + FastAgaveError
#42
Conversation
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 7 +2
Lines 148 169 +21
Branches 21 27 +6
=========================================
+ Hits 148 169 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fast_agave/exception_handlers.py
Outdated
| _: Request, exc: FastAgaveError | ||
| ) -> JSONResponse: | ||
| return JSONResponse( | ||
| status_code=exc.status_code, content=dict(error=exc.detail) |
There was a problem hiding this comment.
Qué va a pasar cuando desde authed venga un CuencaError? Por ejemplo un UserNotLoggedInError
There was a problem hiding this comment.
Las excepciones que vengan de authed deben ser cachadas por el middleware en fast-agave-authed. Estos exceptions handlers solo manejan las que se lancen dentro de un endpoint. fast-agave-authed usa estos mismos exceptions handler
closes #40
closes #41