Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire does not work with 'when' 3.0.0. #155

Closed
jimkang opened this issue Mar 18, 2014 · 3 comments
Closed

Wire does not work with 'when' 3.0.0. #155

jimkang opened this issue Mar 18, 2014 · 3 comments

Comments

@jimkang
Copy link

jimkang commented Mar 18, 2014

Wire does not work with version 3.0.0 of the when module. It instantiates dependencies with the wrong arguments. However, it works fine with when 2.8.0.

Wire's package.json specifies the dependency in package.json like so:

"when": ">=1.5.0 || ~2"

This means that when you currently run npm install, it will use when 3.0.0 instead of a 2.x version.

@briancavalier
Copy link
Member

Hey @jimkang, thanks for the heads up! We were aware of the incompatibility (an update is coming soon), but thought the semver in package.json would do the right thing :( Sorry about that! I'll push an update asap that limits the when version to 2.x.

@jimkang
Copy link
Author

jimkang commented Mar 18, 2014

@briancavalier Thanks for the fix!

@briancavalier
Copy link
Member

No prob, thanks again for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants