Update dependencies #420
Merged
Update dependencies #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectory (#53) When gradle plugin runs [run_build_tool.cmd](https://github.com/irondash/cargokit/blob/a3b7352f9ebea0108d144c26437138f2903d6b35/run_build_tool.cmd) it passes to script env variable `%CARGOKIT_TOOL_TEMP_DIR%`. Then script make `cd` to dir that passed inside this variable. But if this variable points to directory that located on different drive than working directory for script, cd will not work. For it to work we need to pass `/D` parameter to `cd`. I made this change localy and it helps. Right now line [11](https://github.com/irondash/cargokit/blob/a3b7352f9ebea0108d144c26437138f2903d6b35/run_build_tool.cmd#L11) in local my script looks like: ``` cd /D "%CARGOKIT_TOOL_TEMP_DIR%" ``` and it works. This is PR that fix this issue. PS: [my inital issue](superlistapp/super_native_extensions#290)
plugin.gradle: Use variant.buildType.name instead of variant.name. The latter is equal to flavor + buildMode while the former is just buildMode It fixes this issue fzyzcjy/flutter_rust_bridge#1606
Very simple fix to build under NixOS. On NixOS, /bin/bash is not here, so the build failed. So it is much stronger to use /usr/bin/env bash.
Some Linux distributions might have `sha1sum` in the path but `shasum` might be missing. This will create an alias for `shasum` to fallback to `sha1sum` if available. Should close #57
Origin issue: fzyzcjy/flutter_rust_bridge#1840 Origin pr: fzyzcjy/flutter_rust_bridge#1842 Simple problem description: if you create a new flutter_rust project in windows, the sh script is automatically created, but the executable permissions cannot be set. When moving this project to macOS and executing `flutter build ios` to build ipa files the process crashes due to insufficient sh script permissions. This permission problem can be circumvented by `sh script.sh` rather than `script.sh` As verified by Github Action's macOS Runner, the modified cargokit works fine for building ipa apps using the flutter_rust project created on windows. [Action Link](https://github.com/canxin121/new_app_test/actions/runs/8466294309)
When build as a flutter module and integrated into the existing android project, there is no applicationVariants and result in following compilation failure: Could not get unknown property 'applicationVariants' for extension 'android' of type com.android.build.gradle.LibraryExtension. In such case, we will use libraryVariants instead superlistapp/super_native_extensions#379 --------- Co-authored-by: Ji Fang <ji@vistring.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR simply updates dependencies
Before Committing
Please make sure that you've analyzed and formatted the files.