chore: remove for-in (#21)

cuongndc9 · Aug 7, 2020 · 0d5d50b · 0d5d50b
1 parent 3443b0f
commit 0d5d50b
Show file tree

Hide file tree

Showing 9 changed files with 132 additions and 9 deletions.
diff --git a/.idea/codeStyles/Project.xml b/.idea/codeStyles/Project.xml
diff --git a/.idea/codeStyles/codeStyleConfig.xml b/.idea/codeStyles/codeStyleConfig.xml
diff --git a/.idea/hera.iml b/.idea/hera.iml
diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
diff --git a/.idea/modules.xml b/.idea/modules.xml
diff --git a/.idea/vcs.xml b/.idea/vcs.xml
diff --git a/.idea/workspace.xml b/.idea/workspace.xml
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@103cuong/hera-js",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "👩🏼‍💻 Simple and lightweight GraphQL client.",
   "main": "./lib/index.js",
   "types": "./lib/index.d.ts",

diff --git a/src/index.ts b/src/index.ts
@@ -1,17 +1,17 @@
 import axios, { AxiosResponse, AxiosRequestConfig } from 'axios';
 
 function formatVariables(variables: any): any {
-  let formatedVariables = JSON.stringify(variables);
-  formatedVariables = formatedVariables.replace(/"([^"]+)"\s*:\s*/g, '$1:');
-  return formatedVariables;
+  let formattedVariables = JSON.stringify(variables);
+  formattedVariables = formattedVariables.replace(/"([^"]+)"\s*:\s*/g, '$1:');
+  return formattedVariables;
 }
 function formatQuery(query: string, variables: any): string {
-  let formatedQuery = query;
-  for (const key in variables) {
+  let formattedQuery = query;
+  Object.keys(variables).forEach((key) => {
     const regex = new RegExp(`\\$${key}`, 'g');
-    formatedQuery = formatedQuery.replace(regex, formatVariables(variables[key]));
-  }
-  return formatedQuery;
+    formattedQuery = formattedQuery.replace(regex, formatVariables(variables[key]));
+  });
+  return formattedQuery;
 }
 
 interface Option {