Update VisibilityTranslator to handle various edge cases #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Treat `embargo_length == nil` the same as `embargo_length == "None"` * Restrict works with conflicting embargo settings - i.e. `embargo_length != "None"` AND `files_embargoed == toc_embargoed == abstract_embargoed == false` * Add logger warnings and errors to trace unexpected states
1 task
fnibbit
approved these changes
Feb 25, 2021
maxkadel
reviewed
Feb 25, 2021
| @@ -44,10 +45,14 @@ def self.visibility(obj:) | |||
| # When checking whether a value is true, check whether it has a "true" string too. | |||
| def visibility | |||
| return proxy.visibility if obj.hidden? || !obj.under_embargo? | |||
|
|
|||
| return OPEN if embargo_length_none?(obj) | |||
| return ALL_EMBARGOED if obj.abstract_embargoed.to_s == "true" | |||
There was a problem hiding this comment.
I wonder why this has to be forced to a string and compared to a string, rather than being a boolean? Don't know if it's relevant to the weirdness we're having, but it makes me curious.
There was a problem hiding this comment.
There's legacy data migrated that has string values while the new application uses booleans, so the field might have either "true" or 'true stored in Fedora.
I would have preferred to normalize the data at the time of migration, but that's not the choice the team made at the time.
I think we could consider doing that normalization now - I think it would make the data and the code simpler and easier to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue described in #2065
embargo_length == nilthe same asembargo_length == "None"embargo_length == "6 months"BUT
files_embargoed == toc_embargoed == abstract_embargoed == falseBEFORE
AFTER
