Refactor GraduationJob test to be more resilient #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of the job depended on starting with Fedora in a clean state by using the `:clean` tag. Erasing Fedora is an expensive operation that we'd like to avoid when possible. This change set captures the specific ID of the ETD created for the test so that we don't have to rely on a clean Fedora environment and assuming the `last` created ETD is the right one to test..
mark-dce
force-pushed
the
fix_graduation_job
branch
from
c6ca8e1 to
b91eaa1
Compare
maxkadel
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of the job depended on starting with
Fedora in a clean state by using the
:cleantag. Erasing Fedorais an expensive operation that we'd like to avoid when possible.
This change set captures the specific ID of the ETD created for the
test so that we don't have to rely on a clean Fedora environment and
assuming the
lastcreated ETD is the right one to test..