Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed [FM-7]: Fixed issue where spit animation not properly playing on word puzzle if you play the game very quick. #1198

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

bernhardccodev
Copy link
Collaborator

Added clearTimeout handling setTimeout reset animation to idle for wordPuzzle game.

Modified File(s)

  1. gameplay-scene.ts

@bernhardccodev bernhardccodev changed the title Fixed [FM-7]: Fixed issue where spit animation not properly playing on word puzzle if you play quick. Fixed [FM-7]: Fixed issue where spit animation not properly playing on word puzzle if you play the game very quick. Aug 7, 2024
@woodsjohn-codev
Copy link
Collaborator

looks good to me. tested on my local

@@ -484,7 +485,7 @@ export class GameplayScene {
this.stoneHandler.getCorrectTargetStone() == this.tempWordforWordPuzzle &&
isCorrect
) {
this.handleCorrectStoneDrop(feedBackIndex);
this.handleCorrectStoneDrop(feedBackIndex); //handle what text
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernhardccodev can you add proper comment here on this method or you can remove the existing comment as it is not that clear.

@ashwinnair-chimple ashwinnair-chimple merged commit 4447522 into dev-optimization Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants