Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog #1056

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Update changelog #1056

merged 3 commits into from
Jul 1, 2021

Conversation

matt-allan
Copy link
Contributor

Updating the changelog with all the changes from #1051, #1049, and #1041.

@snags88 snags88 temporarily deployed to curology-radiance-pr-1056 July 1, 2021 18:38 Inactive
@snags88 snags88 temporarily deployed to curology-radiance-pr-1056 July 1, 2021 18:44 Inactive
Copy link
Contributor

@michaeljaltamirano michaeljaltamirano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like that libraries like react etc. update the CHANGELOG with Unreleased when working on PRs. I'm good to merge this in as a discrete commit. When I do releases I usually add the CHANGELOG commit with --amend as part of the release commit that happens automatically after running yarn run publish-package so that it's all together: f6a6d7f. Sharing that just as an FYI.

@@ -1,5 +1,17 @@
# CHANGELOG

# v23.0.0

- [Components] Added new `ResetStyles` and `BrandStyles` components to inject global styles. These replace the `utils/injectGlobalStyles/style` exports that were used for the same purpose. ([#1051)](https://github.com/curology/radiance-ui/pull/1051))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nit] This is technically a breaking change 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is but that file was never exported in a documented entrypoint so it's covered by the other breaking change line below 😁

@matt-allan matt-allan merged commit d7f6dfc into master Jul 1, 2021
@matt-allan matt-allan deleted the update-changelog branch July 1, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants