-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update lint staged config #130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daigof
approved these changes
Jul 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
daigof
approved these changes
Jul 1, 2019
snags88
reviewed
Jul 1, 2019
} | ||
}, | ||
"lint-staged": { | ||
"concurrent": false, | ||
"subTaskConcurrency": 1, | ||
"linters": { | ||
"resources/**/!(style|styles|test).js": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol i must have copied this from the pocketderm repo. good find
snags88
approved these changes
Jul 1, 2019
This is great, we should automate these types of checks where we can! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands our
husky
andlint-staged
use.yarn run test
hook so that we can find and fix tests before they fail on CI.prettier
formatting to.md
and.json
filesprettier
formatting tostyle/styles/test.js
files.eslint
on them. I still think we should format them.prettier
formatting andeslint
checking on other source files.resources
does not exist in this repo, so we were neither applyingprettier
nor checking foreslint
warnings/errors before pushing.The intent of this (and #129) is to make greater use of the tools we're using offer. I think we should rely more on auto-formatting to ensure a consistent code style (so we don't have to comment on it in PRs, and so it is easier to read), and to prevent unnecessary CI builds.