[Icons] Remove Title #1327
Merged
[Icons] Remove Title #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been under the impression that including
<title>in our SVG components could support Accessibility, but based on our usage it just makes screen reader messaging more confusing, e.g. instead of "Sometimes, Radio" as the description for our Radio Button for a Sometimes option, it might read "Sometimes Time - Some of the Time Glyph, Radio", since it includes the svg title in there.Our tooling in downstream repos is strong enough that we are handling a11y concerns appropriately, and there's no safe "fallback" to SVG titles, they end up just making the accessibility tree that exists a bit more confusing. This simplifies our setup, too.