Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeScript] Use Generics with Tabs TabType Definition #1329

Merged
merged 1 commit into from
Dec 28, 2021
Merged

[TypeScript] Use Generics with Tabs TabType Definition #1329

merged 1 commit into from
Dec 28, 2021

Conversation

michaeljaltamirano
Copy link
Contributor

We are often executing conditional logic based on the values of the tabs and so we want type information that is stronger than just number or string.

@snags88 snags88 temporarily deployed to curology-rad-typescript-grkz5l December 28, 2021 18:43 Inactive
@michaeljaltamirano michaeljaltamirano merged commit ad57eee into master Dec 28, 2021
@michaeljaltamirano michaeljaltamirano deleted the typescript/update-tabs-type branch December 28, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeljaltamirano @snags88