[Icon Updates] Add / update 3/3 icons from Figma #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daigof
reviewed
Jan 29, 2020
| @@ -37,15 +36,6 @@ class OptionButtonExample extends React.Component { | |||
| type="primary" | |||
| icon={<PlusIcon />} | |||
| /> | |||
| <OptionButton | |||
There was a problem hiding this comment.
was thi removed in other PR?
There was a problem hiding this comment.
sry I refer to the EqualsIcon
There was a problem hiding this comment.
Just aesthetic. The new EqualsIcon is now wrapped in a circle, and so it looked like this:
It's on my radar to check how it's used in the main repos and bring in a designer to decide if any changes are needed, but for this it was just being used as an example for the button, and it it was looking strange next to the plus and minus icons.
There was a problem hiding this comment.
yeah that looks weird.
youngmanalive
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana: https://app.asana.com/0/0/1158576271189801/f
Glyph Updates sheet: https://docs.google.com/spreadsheets/d/1FNiVhL3eV_Vc69JZycn4QAz63HOSXBb4RZAsHSc9XdY/edit?usp=sharing
In this PR:
Note: Some of the icons have substantial design differences between the old and the new, and for those I will be checking both Gatsby and PocketDerm repos once this is published and the package is ready to be updated. There are also some icons which have been renamed, so the old names will be removed in a later PR once those repos have been updated.