[Icon Updates] Remove masks on svgs for glyphs a-m #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngmanalive
approved these changes
Jan 30, 2020
Comment on lines
-6
to
-15
| </g> | ||
| </mask> | ||
| <g mask="url(#mask0)"> | ||
| <rect width="48" height="48" fill="currentColor"/> | ||
| </g> | ||
| <defs> | ||
| <clipPath id="clip0"> | ||
| <rect x="8" y="10" width="32" height="29" fill="white"/> | ||
| </clipPath> | ||
| </defs> |
There was a problem hiding this comment.
i'm sure you're taking notes on these, but we'll prob want to double check the more complicated ones like this.
There was a problem hiding this comment.
Checking as I was updating, they seem unaffected by removing these extra lines, but will definitely check them in the other repos as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that using the masks from the exported Figma SVGs was causing some issues in some use cases with fills (where the fill would cover the whole square of the SVG instead of just the path).
This PR removes the masks on the glyphs A-M